Skip to content

[lora_conversion] Enhance key handling for OneTrainer components in LORA conversion utility (#11441) #11487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iamwavecut
Copy link

@iamwavecut iamwavecut commented May 3, 2025

What does this PR do?

Fixes #11441

I tried to keep changeset somehow minimal, while doing it the same way as it's already done.

Before submitting

Who can review?

@sayakpaul would be the most relevant I suppose.

else:
raise NotImplementedError
raise NotImplementedError(k)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either NotImplementedError or an elaborated error message with NotImplementedError is fine:

Suggested change
raise NotImplementedError(k)
raise NotImplementedError(f"Handling for key ({k}) is not implemented.")

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks! I just ran the integration LoRA tests for Flux and they all pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants