Skip to content

Removes storybook from codebase entirely, including storybook switch feature #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,7 @@ module.exports = {
parser: "@typescript-eslint/parser",
parserOptions: {
tsconfigRootDir: __dirname, // this option prevents us from specifying this file in "eslintConfig" package.json key https://github.com/typescript-eslint/typescript-eslint/issues/251
project: [
"./tsconfig.base.json",
"./apps/*/tsconfig.json",
"./lib/*/tsconfig.json",
],
project: ["./tsconfig.base.json", "./apps/*/tsconfig.json", "./lib/*/tsconfig.json"],
},
settings: {
"import/extensions": [".js", ".jsx", ".ts", ".tsx"],
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/cleanup-all-temp-trusted-branches.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ jobs:
run: |
# Fetch all branches
git fetch --all

# Find branches starting with 'temp-ci-trusted-fork-'
branches_to_delete=$(git branch -r | grep 'origin/temp-ci-trusted-fork-' | sed 's|origin/||')

if [ -z "$branches_to_delete" ]; then
echo "No branches found to delete."
exit 0
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/trust-fork-pr-cleanup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ on:
workflow_dispatch:
inputs:
branch_to_delete:
description: 'Branch to delete'
description: "Branch to delete"
required: true
delete_after:
description: 'Delete after (ISO 8601 date)'
description: "Delete after (ISO 8601 date)"
required: true

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/trust-fork-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_dispatch:
inputs:
pr_number:
description: 'PR number to trust'
description: "PR number to trust"
required: true

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .yarn/releases/yarn-4.1.1.cjs

Large diffs are not rendered by default.

9 changes: 9 additions & 0 deletions .yarnrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,12 @@ npmAuthToken: "${NPM_TOKEN-}"
npmPublishAccess: public

yarnPath: .yarn/releases/yarn-4.1.1.cjs

# Ignore specific warnings
logFilters:
- code: YN0057 # Resolutions field will be ignored
level: discard
- code: YN0060 # Peer dependency issues
level: discard
- code: YN0086 # Some peer dependencies are incorrectly met
level: discard
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,6 @@ On the [Releases](https://github.com/infinitered/reactotron/releases?q=reactotro
- [**MST**](https://docs.infinite.red/reactotron/plugins/mst/)
- [**Redux**](https://docs.infinite.red/reactotron/plugins/redux/)
- [**Open in Editor**](https://docs.infinite.red/reactotron/plugins/open-in-editor/)
- [**Storybook (only for React Native)**](https://docs.infinite.red/reactotron/plugins/storybook/) \
`reactotron-react-native` ships with [Storybook](https://storybook.js.org/).
This enables you to switch to Storybook from the Reactotron app.
- [**Custom Commands**](https://docs.infinite.red/reactotron/custom-commands/)

## Tips and Tricks
Expand Down
4 changes: 1 addition & 3 deletions apps/example-app/app.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@
"fallbackToCacheTimeout": 0
},
"jsEngine": "hermes",
"assetBundlePatterns": [
"**/*"
],
"assetBundlePatterns": ["**/*"],
"android": {
"icon": "./assets/images/app-icon-android-legacy.png",
"package": "com.exampleapp",
Expand Down
4 changes: 2 additions & 2 deletions apps/example-app/app/components/ListView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ const ListViewComponent = forwardRef(
const ListComponentWrapper = isRTL ? FlatList : FlashList

return <ListComponentWrapper {...props} ref={ref} />
},
}
)

ListViewComponent.displayName = "ListView"

export const ListView = ListViewComponent as <T>(
props: ListViewProps<T> & {
ref?: React.RefObject<ListViewRef<T>>
},
}
) => React.ReactElement
4 changes: 2 additions & 2 deletions apps/example-app/app/i18n/i18n.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,5 @@ type RecursiveKeyOfInner<TObj extends object> = {
type RecursiveKeyOfHandleValue<TValue, Text extends string> = TValue extends any[]
? Text
: TValue extends object
? Text | `${Text}${RecursiveKeyOfInner<TValue>}`
: Text
? Text | `${Text}${RecursiveKeyOfInner<TValue>}`
: Text
2 changes: 1 addition & 1 deletion apps/example-app/app/navigators/navigationUtilities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ export function goBack() {
* resetRoot will reset the root navigation state to the given params.
*/
export function resetRoot(
state: Parameters<typeof navigationRef.resetRoot>[0] = { index: 0, routes: [] },
state: Parameters<typeof navigationRef.resetRoot>[0] = { index: 0, routes: [] }
) {
if (navigationRef.isReady()) {
navigationRef.resetRoot(state)
Expand Down
8 changes: 4 additions & 4 deletions apps/example-app/app/services/api/apiProblem.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,31 +37,31 @@ test("handles unknown errors", () => {

test("handles unauthorized errors", () => {
expect(
getGeneralApiProblem({ problem: "CLIENT_ERROR", status: 401 } as ApiErrorResponse<null>),
getGeneralApiProblem({ problem: "CLIENT_ERROR", status: 401 } as ApiErrorResponse<null>)
).toEqual({
kind: "unauthorized",
})
})

test("handles forbidden errors", () => {
expect(
getGeneralApiProblem({ problem: "CLIENT_ERROR", status: 403 } as ApiErrorResponse<null>),
getGeneralApiProblem({ problem: "CLIENT_ERROR", status: 403 } as ApiErrorResponse<null>)
).toEqual({
kind: "forbidden",
})
})

test("handles not-found errors", () => {
expect(
getGeneralApiProblem({ problem: "CLIENT_ERROR", status: 404 } as ApiErrorResponse<null>),
getGeneralApiProblem({ problem: "CLIENT_ERROR", status: 404 } as ApiErrorResponse<null>)
).toEqual({
kind: "not-found",
})
})

test("handles other client errors", () => {
expect(
getGeneralApiProblem({ problem: "CLIENT_ERROR", status: 418 } as ApiErrorResponse<null>),
getGeneralApiProblem({ problem: "CLIENT_ERROR", status: 418 } as ApiErrorResponse<null>)
).toEqual({
kind: "rejected",
})
Expand Down
2 changes: 1 addition & 1 deletion apps/example-app/app/utils/useSafeAreaInsetsStyle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const edgeInsetMap: Record<string, Edge> = {
*/
export function useSafeAreaInsetsStyle(
safeAreaEdges: ExtendedEdge[] = [],
property: "padding" | "margin" = "padding",
property: "padding" | "margin" = "padding"
): Pick<
FlexStyle,
| "marginBottom"
Expand Down
7 changes: 3 additions & 4 deletions apps/reactotron-app/.github/ISSUE_TEMPLATE/issue_template.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
---
name: File An Issue
about: Report an issue with Reactotron
title: ''
labels: ''
assignees: ''

title: ""
labels: ""
assignees: ""
---

If you have a general question, please ask it in the #reactotron channel of the
Expand Down
3 changes: 0 additions & 3 deletions apps/reactotron-app/.storybook/addons.js

This file was deleted.

10 changes: 0 additions & 10 deletions apps/reactotron-app/.storybook/config.js

This file was deleted.

37 changes: 0 additions & 37 deletions apps/reactotron-app/.storybook/webpack.config.js

This file was deleted.

12 changes: 3 additions & 9 deletions apps/reactotron-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@
"format:check": "yarn format --check",
"format:write": "yarn format --write",
"lint": "eslint 'src/**/**.{ts,tsx}'",
"storybook": "start-storybook -p 6006",
"build-storybook": "build-storybook",
"typecheck": "tsc --noEmit",
"ci:test": "yarn test --runInBand"
},
Expand Down Expand Up @@ -77,14 +75,9 @@
"@babel/preset-react": "^7.22.15",
"@babel/preset-typescript": "^7.23.2",
"@electron/notarize": "^2.1.0",
"@storybook/addon-actions": "^5.2.8",
"@storybook/addon-knobs": "^5.2.8",
"@storybook/addon-links": "^5.2.8",
"@storybook/addons": "^5.2.8",
"@storybook/react": "^5.2.8",
"@testing-library/react": "^14.1.2",
"@types/jest": "^29.5.7",
"@types/react": "18.2.45",
"@types/react": "~18.2.79",
"@types/react-dom": "18.2.14",
"@typescript-eslint/eslint-plugin": "^6.7.5",
"@typescript-eslint/parser": "^6.7.5",
Expand All @@ -108,7 +101,8 @@
"react-test-renderer": "18.2.0",
"rimraf": "^5.0.5",
"ts-jest": "^29.1.1",
"typescript": "^4.9.5"
"typescript": "^4.9.5",
"webpack": "^4.47.0"
},
"build": {
"productName": "Reactotron",
Expand Down
2 changes: 0 additions & 2 deletions apps/reactotron-app/src/renderer/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import Timeline from "./pages/timeline"
import Subscriptions from "./pages/state/Subscriptions"
import Snapshots from "./pages/state/Snapshots"
import Overlay from "./pages/reactNative/Overlay"
import Storybook from "./pages/reactNative/Storybook"
import CustomCommands from "./pages/customCommands"
import Help from "./pages/help"

Expand Down Expand Up @@ -62,7 +61,6 @@ function App() {

{/* React Native */}
<Route path="/native/overlay" element={<Overlay />} />
<Route path="/native/storybook" element={<Storybook />} />

{/* Custom Commands */}
<Route path="/customCommands" element={<CustomCommands />} />
Expand Down

This file was deleted.

Loading