This repository was archived by the owner on Jul 20, 2024. It is now read-only.
Fix loop that can run infinitely in some cases #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiranV
changed the title
LiranV
force-pushed
the
fix-infinite-while-loop-snat
branch
from
9771977 to
2ed70d9
Compare
|
Hi @int128 . Edit: actually, it doesn't fix the original problem #57. If interface is not attached for some reason, this change will wait for 3 mins and fail and user will have to handle it using Adding retries in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside the
runonce.shscript there is theaws ec2 attach-network-interfacecommand,If it fails (in my case when the interface was not yet released after system check failure and instance termination) the script goes on and then
snat.shwill run.There the
whileloop will hand as eth1 will never be available due to the previous failure.This fix will allow the control flow to continue and reach a user provided script which is given via the
user_datavariable of this module.