[sql-35]: firewalldb+rpcserver: refactor ListActions #1068
Merged
+284
−147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
added
no-changelog
ellemouton
commented
May 9, 2025
firewalldb/actions_kvdb.go
Outdated
Comment on lines
201
to
204
| // ListActions returns a list of Actions that pass the filterFn requirements. | ||
| // The indexOffset and maxNum params can be used to control the number of | ||
| // actions returned. The return values are the list of actions, the last index | ||
| // and the total count (iff query.CountTotal is set). |
There was a problem hiding this comment.
oops - noticed the duplicate comment now. Will remove after final review round
bitromortac
approved these changes
May 9, 2025
Here we move the filter logic behind the interface so that our sql implementation can make use of indexes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we move the filter logic behind the method so that our sql implementation of ListActions can make use of indexes later on instead of how it is done in the bbolt where the filters are applied in memory.
This is quite a big diff in a single commit - so I'm just dedicating this PR to the single commit to help with review load.