[Incomplete - for discussion] Add bridge-cache plugin to populate cache without running action #5190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benkeen
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L,
dmichon-msft and
patmill
as code owners
dmichon-msft
reviewed
Apr 9, 2025
Comment on lines
76
to
78
| if (!targetProjects.includes(associatedProject.packageName)) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
I'd recommend creating a Set<Operation> that contains all operations where operation.enabled was true prior to cancel and just check for membership in that set here.
benkeen
force-pushed
the
benkeen/cache-bridge-plugin
branch
from
a457102 to
c3fdcc9
Compare
iclanton
reviewed
Apr 30, 2025
| @@ -81,6 +81,7 @@ export class PluginManager { | |||
| tryAddBuiltInPlugin('rush-amazon-s3-build-cache-plugin'); | |||
| tryAddBuiltInPlugin('rush-azure-storage-build-cache-plugin'); | |||
| tryAddBuiltInPlugin('rush-http-build-cache-plugin'); | |||
| tryAddBuiltInPlugin('rush-bridge-cache-plugin'); | |||
There was a problem hiding this comment.
This plugin shouldn't be installed by default, so make sure this gets removed before checkin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*** This is incomplete. For discussion only. Will add proper doc later.
The goal is to add a plugin which allows users to run a Rush command, but only populate the cache from a previous run of that action, not actually run the command. In other words, it relies on a build having already taken place.
For instance:
Each of these would populate the cache for one or more package actions from whatever was on disk. The command itself (build, test, lint) won't get run.
Why?
We're using a different build orchestrator to handle some high-volume builds (BuildXL), primarily because it's able to farm out work across agents, not just processes. As a build orchestrator, it does exactly the same work as what Rush would have done, but has a totally different cache to Rush. We rely on our current (Rush) pipeline populating the remote cache so our local builds are snappy. Without the feature in this PR, we'd need a separate pipeline to populate the Rush cache - which is very wasteful + expensive.