ENH: support auto and fsaverage for add_trans in report #13232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappelhoff
requested review from
hoechenberger,
dengemann and
jasmainak
as code owners
sappelhoff
requested review from
larsoner,
drammock and
agramfort
as code owners
larsoner
reviewed
Apr 28, 2025
larsoner
reviewed
Apr 28, 2025
Comment on lines
+234
to
+252
| if subject is None: | ||
| if "SUBJECT" in os.environ: | ||
| subject = os.environ["SUBJECT"] | ||
| else: | ||
| raise ValueError( | ||
| "subject is None and SUBJECT environment variable not set, cannot " | ||
| "use trans='auto'" | ||
| ) | ||
| glob_str = str(subjects_dir / subject / "*-trans.fif") | ||
| trans_fnames = glob.glob(glob_str) | ||
| if len(trans_fnames) < 1: | ||
| raise RuntimeError( | ||
| f"Could not find the transformation for {subject} in: {glob_str}" | ||
| ) | ||
| elif len(trans_fnames) > 1: | ||
| raise RuntimeError( | ||
| f"Found multiple transformations for {subject} in: {glob_str}" | ||
| ) | ||
| trans = Path(trans_fnames[0]) |
There was a problem hiding this comment.
These lines are just indentation plus improved error message (giving the user the glob string to help them understand why the trans wasn't found)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fsaverageforsubjectinmne.Report.add_trans#13224