-
Notifications
You must be signed in to change notification settings - Fork 30
Final Draft for IoT Datahub Smart Manufacturing Solution #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: solutions-poc
Are you sure you want to change the base?
Final Draft for IoT Datahub Smart Manufacturing Solution #195
Conversation
✅ Deploy Preview for docs-atlas-architecture ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rakshit1798 thanks for this draft! Overall looks really good, just have a few comments to clean up some build errors in the logs.
`time-series collections <https://www.mongodb.com/docs/manual/core/timeseries/timeseries-procedures/#insert-measurements-into-a-time-series-collection>`__ . | ||
For example: | ||
|
||
.. code-block:: sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should start at column 1, meaning we'll need to adjust the indentation for the contained code accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Jeff, adding the code block to column 1 is leading to errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't be 🤔 I see that right now with the current formatting we have this error:
ERROR(solutions-library/IoT-datahub-manufacturing.txt:119ish): Unexpected indentation
This is because it's expecting .. code-block:: sh
to appear at column 1, rather than indented as it is currently. When you move it to column 1, what is the error you're seeing?
Description
Migrate the IoT Smart Hub Industry Solutions article to docs.
Staging