feat(integrations): added django integration #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-fatalyst
requested changes
Apr 25, 2025
| @@ -0,0 +1,117 @@ | |||
| import json | |||
There was a problem hiding this comment.
I removed the use of this library. Please use pydantic_core instead.
|
|
||
| outer = self | ||
|
|
||
| @csrf_exempt |
There was a problem hiding this comment.
I think it will block access from Swagger. It should be something like this:
def _create_or_update_view(self, path: str, method: str, endpoint: Callable):
view = self._views.get(path)
if not view:
view = type("DynamicView", (View,), {
"dispatch": csrf_exempt(View.dispatch)
})
self._views[path] = view
method_name = method.lower()
outer = self
def handle(self, req, **path_params):
return outer._handle_request(endpoint, req, **path_params)
setattr(view, method_name, handle)
return view
|
|
||
| assert response.status_code == 200 | ||
| assert "text/html" in response.headers["content-type"] | ||
| assert "redoc" in response.text |
There was a problem hiding this comment.
You used HttpResponse in _handle_request. This class does not have text. It has to be content with .decode().
| except Exception as e: | ||
| error_response = self.handle_exception(e) | ||
| return JsonResponse(error_response, status=getattr(e, "status_code", 500)) | ||
| result = self._serialize_response(result) |
There was a problem hiding this comment.
I think it would be better to use JsonResponse instead.
result = self._serialize_response(result)
response = HttpResponse(status=status_code)
if result:
json.dump(result, response)
response.headers["Content-Type"] = "application/json"
return response
should be changed to something like this:
result = self._serialize_response(result)
return JsonResponse(result if result is not None else {}, status=status_code)
What do you think?
| @router.get( | ||
| "/posts/", tags=["Posts"], response_errors=[500], response_model=list[PostSchema] | ||
| ) | ||
| async def get_posts(body: FilterPostSchema) -> list[PostSchema]: |
There was a problem hiding this comment.
DjangoRouter can't work with async.
| @router.delete( | ||
| "/posts/{post_id}", tags=["Posts"], status_code=204, response_errors=[400, 404, 500] | ||
| ) | ||
| async def delete_post(post_id: int) -> None: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
#9 Closes
What’s Included?