Skip to content

Do not throw general exceptions from generated data types #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PhantomGrazzler
Copy link
Contributor

Updated data type generator so that DataTypeException is thrown instead of a general exception for component access methods.

@github-actions
Copy link

github-actions bot commented Nov 21, 2022

Unit Test Results

1 372 tests   1 284 ✔️  4s ⏱️
       3 suites       88 💤
       3 files           0

Results for commit 44b0c2e.

♻️ This comment has been updated with latest results.

@milkshakeuk
Copy link
Member

@PhantomGrazzler FYI I have seen this, didn't want you to think it was being ignored, just need to find the time.

@milkshakeuk milkshakeuk force-pushed the master branch 4 times, most recently from af27245 to 5fb8ffa Compare December 20, 2023 22:47
@milkshakeuk milkshakeuk force-pushed the do_not_throw_general_exceptions_from_generated_data_types branch from 44b0c2e to 7970554 Compare April 9, 2025 11:59
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

1 similar comment
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@milkshakeuk milkshakeuk force-pushed the do_not_throw_general_exceptions_from_generated_data_types branch 2 times, most recently from 28d4513 to 38c632d Compare April 9, 2025 13:44
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (53ce425) 1020600 22935 2.25%
Head commit (38c632d) 1020600 (+0) 22935 (+0) 2.25% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#390) 5 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link

codacy-production bot commented Apr 9, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (212ff2d) 1020600 22935 2.25%
Head commit (137af74) 1020600 (+0) 22935 (+0) 2.25% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#390) 5 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

…ad of a general exception for component accessor methods.
@milkshakeuk milkshakeuk force-pushed the do_not_throw_general_exceptions_from_generated_data_types branch from 38c632d to 137af74 Compare April 9, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants