feat!: end of support for v14 and v16 #6223
Conversation
|
This pull request adds or modifies JavaScript ( |
mrstork
force-pushed
the
update-node-engine-field
branch
from
1e41f6e to
19bd568
Compare
mrstork
force-pushed
the
update-node-engine-field
branch
from
19bd568 to
9af51da
Compare
mrstork
force-pushed
the
update-node-engine-field
branch
from
9d052ce to
33dfed8
Compare
|
This pull request adds or modifies JavaScript ( |
1 similar comment
|
This pull request adds or modifies JavaScript ( |
mrstork
force-pushed
the
update-node-engine-field
branch
from
305b6a5 to
8a3ce46
Compare
|
This pull request adds or modifies JavaScript ( |
mrstork
force-pushed
the
update-node-engine-field
branch
from
8a3ce46 to
c0483d1
Compare
|
This pull request adds or modifies JavaScript ( |
mrstork
force-pushed
the
update-node-engine-field
branch
from
c0483d1 to
f672279
Compare
|
This pull request adds or modifies JavaScript ( |
| test('Validate --node-path version is supported by the plugin', async (t) => { | ||
| const systemLog = await tmp.file() | ||
|
|
||
| const nodePath = getNodePath('16.14.0') | ||
| const output = await new Fixture('./fixtures/engines') | ||
| .withFlags({ | ||
| nodePath, | ||
| featureFlags: { build_warn_upcoming_system_version_change: true }, | ||
| systemLogFile: systemLog.fd, | ||
| debug: false, | ||
| }) | ||
| .runWithBuild() | ||
| t.true(normalizeOutput(output).includes('The Node.js version is 1.0.0 but the plugin "./plugin.js" requires >=1.0.0')) | ||
| const systemLogContents = await fs.readFile(systemLog.path, 'utf8') | ||
| await systemLog.cleanup() | ||
|
|
||
| t.true(systemLogContents.includes('plugin "./plugin.js" node support range includes v22')) | ||
| }) | ||
|
|
There was a problem hiding this comment.
Should this be completely removed and not adjusted to have fixture have engines.node requiring higher version than 18.17 (? I'm not sure if I do read this test right)
Also the 1.0.0 assertions tripped me out, but seems like that's because of version normalization -
build/packages/testing/src/normalize.ts
Lines 116 to 117 in 6099258
and the output of this test today is:
The Node.js version is 16.14.0 but the plugin "./plugin.js" requires >=18.0.0
so I wonder wether instead we should do the bumps so node version IS in @netlify/build supported range, but plugin still require higher version than that
Summary
Part of FRB-1780
Notes:
(see URL.canParse Error in Corepack Brew Formula with pnpm and use-node-version pnpm/pnpm#7724)
Prior to merging:
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)