Skip to content

doc: fix typo of file http.md, outgoingMessage.setTimeout section #58188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2025
Merged

doc: fix typo of file http.md, outgoingMessage.setTimeout section #58188

merged 1 commit into from
May 11, 2025

Conversation

samuel871211
Copy link
Contributor

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels May 6, 2025
@daeyeon daeyeon added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 6, 2025
mhdawson
mhdawson approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2025
@nodejs-github-bot nodejs-github-bot merged commit 917600c into nodejs:main May 11, 2025
31 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 917600c

@samuel871211 samuel871211 deleted the fixTypoOfHttpMd branch May 12, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@pimterry pimterry pimterry approved these changes

@daeyeon daeyeon daeyeon approved these changes

@mhdawson mhdawson mhdawson approved these changes

@aymen94 aymen94 aymen94 approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@samuel871211 @nodejs-github-bot @lpinca @pimterry @daeyeon @mhdawson @aymen94 @Ethan-Arrowood @marco-ippolito @aduh95