inspector: add mimeType and charset support to Network.Response #58192
+235
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
islandryu
commented
May 6, 2025
Comment on lines
+127
to
+130
| common.mustCall(({ params }) => { | ||
| assert.strictEqual(params.response.mimeType, ''); | ||
| assert.strictEqual(params.response.charset, ''); | ||
| }) |
There was a problem hiding this comment.
When the Content-Type header is not set, Chromium also assigns an empty string.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58192 +/- ##
==========================================
- Coverage 90.15% 90.12% -0.03%
==========================================
Files 630 629 -1
Lines 186756 186670 -86
Branches 36652 36635 -17
==========================================
- Hits 168361 168231 -130
- Misses 11192 11215 +23
- Partials 7203 7224 +21
🚀 New features to boost your workflow:
|
anonrig
reviewed
May 7, 2025
| const contentType = contentTypeKeyIndex !== -1 ? response.headers[contentTypeKeyIndex + 1].toString() : ''; | ||
| const mimeTypeObj = new MIMEType(contentType); | ||
| mimeType = mimeTypeObj.essence || ''; | ||
| charset = mimeTypeObj.params.get('charset'); |
There was a problem hiding this comment.
Charset can be undefined/null if this does not exist. I don't think we want that.
There was a problem hiding this comment.
I overlooked this case.
Like mimeType, I’ve set it to an empty string.
jasnell
approved these changes
May 12, 2025
legendecas
reviewed
May 12, 2025
| }) | ||
| ); | ||
| }), | ||
| 2 |
There was a problem hiding this comment.
This seems indented out of order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #53946
It supports the mimeType and charset defined in Network.Response.
https://chromedevtools.github.io/devtools-protocol/tot/Network/#type-Response