Skip to content

src: add a couple fast apis in node_os #58210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: add a couple fast apis in node_os #58210

wants to merge 1 commit into from
+71 −4

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented May 7, 2025

Couple of small fast api additions

@jasnell jasnell requested review from mcollina and anonrig May 7, 2025 04:41
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. os Issues and PRs related to the os subsystem. labels May 7, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66669/

@codecov Codecov
Copy link

codecov bot commented May 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (6184730) to head (8ace295).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58210      +/-   ##
==========================================
+ Coverage   90.18%   90.21%   +0.02%     
==========================================
  Files         631      633       +2     
  Lines      186690   186852     +162     
  Branches    36666    36677      +11     
==========================================
+ Hits       168360   168560     +200     
+ Misses      11126    11093      -33     
+ Partials     7204     7199       -5
Files with missing lines Coverage Δ
src/node_external_reference.h 100.00% <ø> (ø)
src/node_os.cc 79.64% <100.00%> (+0.99%) ⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

BridgeAR
BridgeAR reviewed May 7, 2025
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is LGTM, it would just be good to get some rests that verify the behavior as well.

anonrig
anonrig reviewed May 7, 2025
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @BridgeAR, can we add some tests?

mcollina
mcollina approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jasnell jasnell force-pushed the jasnell/os-fast-apis branch 2 times, most recently from e7847f4 to 5d581b4 Compare May 12, 2025 08:23
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 12, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/66772/ 💛

@jasnell jasnell force-pushed the jasnell/os-fast-apis branch from 5d581b4 to 8ace295 Compare May 12, 2025 17:17
jasnell added a commit that referenced this pull request May 12, 2025
@jasnell
src: add a couple fast apis in node_os
292263e 
PR-URL: #58210
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@jasnell
Copy link
Member Author

jasnell commented May 12, 2025

Landed in 292263e

@jasnell jasnell closed this May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@mcollina mcollina mcollina approved these changes

@addaleax addaleax addaleax approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. os Issues and PRs related to the os subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @nodejs-github-bot @mcollina @addaleax @anonrig @BridgeAR