fix(ColorPicker): make thumbs touch draggable #4101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves ColorPicker part of #3291
❓ Type of change
📚 Description
Currently both thumbs of color picker are not draggable on touch screens. When you try to drag it the browser will try to scroll the whole page instead. It makes mobile users experience worse, since they need to precisely tap the right place.
My solution is to add the
touch-action: none;property to both selector containers to tell browsers that touches inside these two containers should not scroll/pan/zoom the page. It solves the bug, while not breaking touch-scrolling outside of the containers.📝 Checklist