BUG: Raise ValueError for non-string columns in read_json orient='table' (GH19129) #61359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
mroeschke
reviewed
Apr 28, 2025
| @@ -372,6 +372,11 @@ def parse_table_schema(json, precise_float: bool) -> DataFrame: | |||
| pandas.read_json | |||
| """ | |||
| table = ujson_loads(json, precise_float=precise_float) | |||
| fields = table["schema"]["fields"] | |||
There was a problem hiding this comment.
Can you replace other instances of table["schema"]["fields"] below with fields?
mroeschke
reviewed
Apr 28, 2025
| @@ -372,6 +372,11 @@ def parse_table_schema(json, precise_float: bool) -> DataFrame: | |||
| pandas.read_json | |||
| """ | |||
| table = ujson_loads(json, precise_float=precise_float) | |||
| fields = table["schema"]["fields"] | |||
|
|
|||
| if any(not isinstance(field["name"], str) for field in fields): | |||
There was a problem hiding this comment.
Suggested change
| if any(not isinstance(field["name"], str) for field in fields): | |
| if not all(isinstance(field["name"], str) for field in fields): |
NIt: IMO this reads a little clearer with me
mroeschke
added
Error Reporting
|
Hi, it seems there is already a PR #60945 addressing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking forward to feedback. Thanks!