Add fetch() support to LongPoll when XMLHTTPRequest is not available #6181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice! I'd love to see an extra test here that mocks XMLHTTPRequest to undefined or whatever and then expects the respecting fetch calls. |
…is used based on the environment
|
Sure! I've added those in 👍 |
SteffenDE
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we noticed that when opening a socket in a ServiceWorker and using
LongPoll, the socket fails because neitherXMLHTTPRequestorXDomainRequestare available in the ServiceWorker scope.I realise this is a bit of an edge case, as if you have ServiceWorker support, you probably already have native
WebSocketsupport. In our instance, we sometimes fall back to LongPoll when network conditions block connections.To work around this, I've added support for using
fetch, which is in the global scope of a ServiceWorker. To ensure we don't break any existing setups,LongPollrequests still preferXDomainRequestandXMLHTTPRequestin the same ordering as before; this only acts as a fallback when neither are available.