GH-131688: Mark instructions and uops with DECREF_INPUTS as escaping. #133501
+23
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -832,7 +832,7 @@ def compute_properties(op: parser.CodeDef) -> Properties: | |||
| ) | |||
| error_with_pop = has_error_with_pop(op) | |||
| error_without_pop = has_error_without_pop(op) | |||
| escapes = bool(escaping_calls) | |||
| escapes = bool(escaping_calls) or variable_used(op, "DECREF_INPUTS") | |||
There was a problem hiding this comment.
Why does the cases generator not automatically detect this as an escaping call? Special casing it here seems fragile.
There was a problem hiding this comment.
No UPPERCASE calls are treated as escaping, since we just assume they’re macros or DSL magic. Maybe we should remove that rule and just add all of the existing stuff to the non-escaping allowlist?
There was a problem hiding this comment.
DECREF_INPUTS is not treated as an escaping call. We treat it specially.
So we'd need to add it to the whitelist and still add this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DECREF_INPUTS()should be escaping #131688