gh-133537: only use console when available

[maxbachmann]

Alternatively to always returning false the function could only be available when the partition supports console io. Similar to the functions in winconsoleio which are only available when the partition supports console io.

• Issue: nt._supports_virtual_terminal missing guard for console io #133537

[sharktide]

Please explain your changes and how they help in a more understandable way so the review process can go a lot faster :) TiA

[maxbachmann]

GetConsoleMode is only available when HAVE_WINDOWS_CONSOLE_IO is defined. Using it without the guard fails to compile on platforms like the xbox where console io isn't available.

I wasn't sure whether this should get a news entry. If it should I can add one.

[sharktide]

I wasn't sure wheter this should get a news entry. If it should I can add one

In this case it doesn't really matter, since XBox and similar partitions aren't commonly used by CPython developers.

@ZeroIntensity what do you think

[ZeroIntensity]

I have absolutely no idea if we support compiling on XBox (if we do, that's sort of hilarious), but we do accept changes for unsupported platforms, which do need blurb entries. I'm not enough of an expert here to deal with this any further.

@chris-eibl, I heard you know a thing or two about Windows. Would you mind looking at this?

[chris-eibl]

@maxbachmann already improved building on xbox in the past - #102256 was quite a big task.

This looks good to me, just needs a blurb entry.

Pinging @zooba for final steps.

[zooba]

Going to have to wait until beta 1 gets released, but yeah, this is fine.

And we totally support building on Xbox, plenty of games have embedded Python in the past and we want that to be able to continue. We don't have a ready release though, but Max has done a ton of work in the past to make it work nicely. Xbox OS is basically just a modified version of Windows¹, so everything works the same, but there are some differences in what APIs are available so that it's easier to trust any apps.

Footnotes

1. Very vague description, but I'm not sure how much I can share publicly about how it's put together. ↩

[sharktide]

This PR seems to be good, but we will have to wait until Beta 1 gets released as zooba said