Gen modes: Remove -Wno-mismatched-tags
#4011
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Is it even possible to be more thorough? #buildall - Be so, so thorough #buildmore - Be thorough #buildsonlynotests - No runtime effects! - If you approve of this diff, please use the "Accept & Ship" button ig-no-test - Doesn't require Instagram testing. allow-large-files - If you approve of this diff, please use the "Accept & Ship" button :-) **Please avoid revert.** 3,000+ diffs were landed testing parts of this change. This change also underwent extensive CI testing (see above). Reverting invalidates large pieces of the RE cache and is likely much more expensive than fixing the few problems this diff is likely to surface. I apologize for any inconvenience: I'm doing my best with the infrastructure available to me and doing my best to improve that infrastructure also. Reviewed By: q10 Differential Revision: D73536513
|
This pull request was exported from Phabricator. Differential Revision: D73536513 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
#buildall - Be so, so thorough
#buildmore - Be thorough
#buildsonlynotests - No runtime effects!
ig-no-test - Doesn't require Instagram testing.
allow-large-files
Please avoid revert. 3,000+ diffs were landed testing parts of this change. This change also underwent extensive CI testing (see above). Reverting invalidates large pieces of the RE cache and is likely much more expensive than fixing the few problems this diff is likely to surface. I apologize for any inconvenience: I'm doing my best with the infrastructure available to me and doing my best to improve that infrastructure also.
Reviewed By: q10
Differential Revision: D73536513