-
Notifications
You must be signed in to change notification settings - Fork 593
Update yaml configs. Add validation dataset #2608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2608
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated FailureAs of commit 154ab9d with merge base 529d2d8 ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
||
# we need to manually build the mistral classifier model | ||
# because our reward model checkpoint has a larger vocabulary size (due to an added padding token) | ||
reward_and_value_model: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like an accidental change and probably could be worth putting back for the PPO recipe to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
dataset_val: | ||
_component_: torchtune.datasets.alpaca_cleaned_dataset | ||
split: train[95%:] | ||
batch_size_val: 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For many of the larger models this batch size may be too high and result in OOM.
@krammnic thank you for opening this PR. One last change: could you actually set I'm happy to merge after this. |
Hey, sure! |
@SalmanMohammadi This is really weird |
I think you also need to remove the fields from configs for recipes which we don't support validation datasets for: QAT, and LoRA and FFT single device. |
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
Changelog
What are the changes made in this PR?
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install
)pytest tests
pytest tests -m integration_test
UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example