Add Option to Build As Shared Library With Position Independent Code #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Suggestion: Configure the tests to consume all of the different linking options. Use cmake presets to setup easy execution of the tests with those options. Edit: |
… dynamic, also made tinyxml2 always build as static.
…ccess to required code.
MaximilienNaveau
approved these changes
Feb 19, 2025
* Added cmake parameter qualisys_cpp_sdk_OUTPUT_TYPE Replaced qualisys_cpp_sdk_BUILD_SHARED and qualisys_cpp_sdk_BUILD_SHARED_VERSIONED with qualisys_cpp_sdk_OUTPUT_TYPE * Added output_type to build actions
EmilRosenquist
approved these changes
Feb 20, 2025
qjgn
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PR aimed at adding the ability to build the SDK as a dynamic library with -fPIC and release flags contained multiple comments / suggestions from MaximilienNaveau.
Here we implement the suggestions from that PR as well as adding build-options for building as shared/dynamic with or without versioning.
Tests Run