Skip to content

Convert blog post titles to h1 while keeping the styles #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bhumi1102
Copy link

This PR addresses this SEO task

  • Update the blog post tiles and "category" headings while are displayed in the same location on /blog
  • Update styles to maintain current font size and weight, otherwise the blog post titles look too huge (screenshot attached).

@bhumi1102
Copy link
Author

CC: One more SEO task @AmandaPerino, @jathayde

@bhumi1102
Copy link
Author

Without css update, the titles look like this:

before:
Screen Shot 2025-05-01 at 10 11 44 AM
after:
Screen Shot 2025-05-01 at 10 12 31 AM

@jathayde
Copy link
Contributor

jathayde commented May 9, 2025

@bhumi1102 looking at the code we've got a few things to namespace to make this work I feel. So the headlines are defined as .common-headline hn where n is the number 1-6 and then there's a mobile-first responsive style for min-width: 1024px. This is defined in _sass/common/headline.scss.

For these particular pages, the div is classed with .post so we could say .post h1 and then copy in the H2 items either on headline.scss or post.scss (I feel the latter makes more sense.

How do you feel about that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants