fix: handle both bytes and string Redis keys when decode_responses=True #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue #24 where Redis key decoding would fail when a client was configured with decode_responses=True. Adds a new `safely_decode` utility function that handles both bytes and string keys.
bsbodden
requested review from
tylerhutcherson
and removed request for
tylerhutcherson
|
@tylerhutcherson an experimental PR to test the bytes/string encoding issue. Some CI issues on this one, will let it sit and handle it before the release (or push it for the next one, it's not critical) |
| @@ -81,3 +83,22 @@ def from_storage_safe_id(value: str) -> str: | |||
| return "" | |||
| else: | |||
| return value | |||
|
|
|||
|
|
|||
| def safely_decode(key: Union[bytes, str]) -> str: | |||
There was a problem hiding this comment.
@bsbodden good news -- https://github.com/redis/redis-vl-python/blob/9f22a9ad4c2166af6462b007833b456448714dd9/redisvl/redis/utils.py#L20
We have this util already in redisvl that is tested and should work for this use case :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #24 where Redis key decoding would fail when a client
was configured with decode_responses=True. Adds a new
safely_decodeutility function that handles both bytes and string keys.