More idiomatic logging to Rerun #23
Open
+181
−533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxkitsune
force-pushed
the
gijs/more-idiomatic
branch
from
fe5ca33 to
58db705
Compare
oxkitsune
force-pushed
the
gijs/more-idiomatic
branch
from
430d46c to
7411aca
Compare
|
FYI I think there is a version that breaks 0.22 comptatibility: I think this This seems to not work on 0.22 |
|
FYI, it's ok to be merge for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Port some changes from another demo to this example. This fixes a few issues and makes the way meshes are logged more idiomatic.