Skip to content

Updated lang path getting mechanism #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

m0stwan1ed
Copy link

Defining of localization folder has been updated: Laravel 9 has new lang folder path: '/lang', this causes an exception: 'resources/lang doesn't exists!' during the files creation.

In Laravel 5.0 (also available in newer version) App::langPath() method has been added, which helps to get lang folder absolute path, so there is no need to manually build path to lang folder anymore

Defining of localization folder has been updated: Laravel 9 has new lang folder path: '/lang', this causes an exception: 'resources/lang doesn't exists!' during the files creation.
Updated lang path getting mechanism
@rmariuzzo
Copy link
Owner

Thank you @m0stwan1ed for you contribution. I was reading through pending PR and I included an option to specify the language directory. Apart from that, do you consider this PR needed?

@wilpat
Copy link
Contributor

wilpat commented Aug 26, 2022

@rmariuzzo i think #170 can be extended to use langPath() as a fallback

This way, it does two things:

  1. Support subsequent updates to this directory out of the box without needing the config file updated.

  2. Allows users specify their own directory in case they don’t want to use the native lang folder that ships with Laravel.

@rmariuzzo
Copy link
Owner

@wilpat also there's another request that does that too: #166

I'm willing to combine both effort when possible.

@wilpat
Copy link
Contributor

wilpat commented Aug 26, 2022

Awesome, thanks.

@m0stwan1ed m0stwan1ed closed this Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants