Skip to content

Fix errorprone warnings #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from
Draft

Conversation

inv-jishnu
Copy link
Contributor

@inv-jishnu inv-jishnu commented Apr 30, 2025

Description

This PR fixes error prone and java doc warnings and renamed logger param used from LOGGER to logger.
This PR was created based on following feedback from PR #2591.

Related issues and/or PRs

#2591

Changes made

I have made the following changes

  • Renamed LOGGER to logger
  • Changed assert to assertThat
  • Added SAME_NAME_BUT_DIFFERENT to ignore patterns that need to be ignored for data loader core project
  • Added suppress warning for SameNameButDifferent and MissingSummary and a few more.
  • Fixed few warning with minor code changes
  • Removed and unused class and a method

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

NA

Release notes

Fix warnings for java doc and error prone

@inv-jishnu inv-jishnu added the enhancement New feature or request label Apr 30, 2025
@inv-jishnu inv-jishnu self-assigned this Apr 30, 2025
@inv-jishnu inv-jishnu marked this pull request as draft April 30, 2025 04:25
@inv-jishnu inv-jishnu mentioned this pull request Apr 30, 2025
6 tasks
Base automatically changed from feat/data-loader/import-log-2 to master May 8, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants