Skip to content

Change slog to tracing in comments #7378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 6, 2025
Merged

Change slog to tracing in comments #7378

merged 3 commits into from
May 6, 2025
+1 −2

Conversation

chong-he
Copy link
Member

@chong-he chong-he added the ready-for-review The code is ready for review label Apr 30, 2025
macladson
macladson requested changes Apr 30, 2025
View reviewed changes
Copy link
Member

@macladson macladson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can be more precise here and mention the actual trait we are implementing like the original comment

@macladson macladson added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels May 6, 2025
@mergify mergify bot merged commit 43c38a6 into sigp:unstable May 6, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macladson macladson macladson approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chong-he @macladson