Add a default timeout to all BeaconNodeHttpClient requests
#7400
+27
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
added
val-client
jimmygchen
force-pushed
the
add-bn-http-client-timeout
branch
from
a6455d7 to
16553c9
Compare
michaelsproul
approved these changes
May 6, 2025
michaelsproul
added
v7.0.2
|
Dropping this from v7.0.2 as it doesn't fix the freezes. Happy for it to be re-targeted at |
michaelsproul
added
waiting-on-author
jimmygchen
force-pushed
the
add-bn-http-client-timeout
branch
from
16553c9 to
4483a7f
Compare
jimmygchen
added
ready-for-review
michaelsproul
added
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Add a default request timeout to all
BeaconNodeHttpClientrequests to ensure that no HTTP request can hang indefinitely.