ensure generateId executes on the scheduler thread specified by publishOn #3711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @spencergibb, I recently came across this code, which is intended to prevent the execution of
uuid generate
on the main thread. However, after applying themap
function, the publisher returned bypublishOn
is no longer aMonoSubscribeOnCallable
, but rather aMonoPublishOn
. As a result, the first execution ofidGenerator::generateId
actually still occurs on the thread that subscribes to it.spring-cloud-gateway/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/route/CompositeRouteDefinitionLocator.java
Lines 67 to 69 in 0affb76