Fix for parameter position Error that occurs when binding the same Collection multiple times in R2DBC DatabaseClient

[Tussle0410]

While developing with R2DBC DatabaseClient, an error occurred with the message 'Parameter at position 3 is not set' during the process of binding a Collection multiple times.

[Example SQL]

SELECT * 
FROM PERSON
WHERE name IN (:ids)
GROUP BY address

UNION

SELECT * 
FROM PERSON
WHERE name NOT IN (:ids)

[Execute Code]

    List<String> ids = List.of("1", "2", "3");

    return databaseClient.sql(query)
        .bind("ids", ids)
        .map((row, rowMetadata) -> row.get("name", String.class))
        .all();

[Exception]

java.lang.IllegalStateException: Parameter at position 3 is not set

When debugging the related code, we confirmed that while it was retrieving the marking and index information, it was replacing the Collection values with information that had only been marked once.

We modified the code that replaces Collections according to marking and index information to ensure it doesn't execute only once, and we've written related test code.

[Modified]
When binding a Collection multiple times, n BindMarkers are created for the collection, so we modified the code to repeat the marking process if there is remaining mark information for the collection, ensuring the binding process executes n times.

[sbrannen]

Hi @Tussle0410,

Thanks for raising the issue and simultaneously submitting a proposed fix.

However, this issue was already reported a few weeks ago in #34768, and I just pushed a fix in dd6eede.

In light of that, I am closing this as a ...

• Duplicate of R2DBC NamedParameterUtils only expands reused collection parameter once #34768