Skip to content

Add Support Extracting DN From X500Principal #16984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

franticticktick
Copy link
Contributor

Closes gh-16980

Closes spring-projectsgh-16980

Signed-off-by: Max Batischev <mblancer@mail.ru>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 23, 2025
@jzheaux jzheaux added this to the 7.0.x milestone Apr 23, 2025
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 1, 2025
@rwinch
Copy link
Member

rwinch commented May 6, 2025

Thanks for the PR @franticticktick

Upon review, I think that it makes more sense to deprecate and create a SubjectX500PrincipalExtractor class that extracts using getSubjectX500Principal.

What are your thoughts @jzheaux ?

@rwinch rwinch self-assigned this May 6, 2025
@jzheaux
Copy link
Contributor

jzheaux commented May 7, 2025

Yes, @rwinch, I agree. Originally, I was trying to be a bit more conservative and reuse what we have, but I believe a new implementation will allow for a name that clearly indicates what it's for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SubjectDnX509PrincipalExtractor should update to getSubjectX500Principal
4 participants