Skip to content

feat(completions): fill in alias for columns in join clauses #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2025

Conversation

juleswritescode
Copy link
Collaborator

Given a query

select 
  email, id
from
  auth.users u
  join auth.identities i on {}

if you pick user_id from the list, it will fill in i.user_id now.

@juleswritescode
Copy link
Collaborator Author

@psteinroe Should we also fill in aliases in select clauses?
It would be cool to do this only if we have duplicate columns, but that's odd to implement with the current design.
We could also simply always add the alias. WDYT?

@juleswritescode juleswritescode requested a review from psteinroe May 7, 2025 06:39
@juleswritescode juleswritescode merged commit be94461 into main May 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants