-
Notifications
You must be signed in to change notification settings - Fork 23
[WIP] Kinetis KE02 platform support #377
base: develop
Are you sure you want to change the base?
Conversation
iia
commented
Apr 29, 2018
- Add UART driver and integrate it with the bus and console layers.
- Working semaphore and timer configuration using internal clock.
- User program demonstrates console usage with delay.
Some libraries becomes optional to avoid unnecessary cloning of whole submodules set. Architecture module is extended with possibility of using NVIC-names interrupts. New startup assembly file is also added.
Found in KE02 platform.
Applications can override default stubs as well as provide own library implementation.
Without this instruction, watchdog cannot be properly re-configured.
…exp_support Conflicts: CMakeLists.txt arch/arm_cm/CMakeLists.txt arch/arm_cm/startup_arm_cm.S build_api.cmake lib/CMakeLists.txt lib/fs/CMakeLists.txt lib/newlib/CMakeLists.txt platform/common/CMakeLists.txt platform/tm4c/mcu_cfg.cmake sys/sys.cpp
1. Add UART driver and integrate it with the bus and console layers. 2. Working semaphore and timer configuration using internal clock. 3. User program demonstrates console usage with delay.
Can one of the admins verify this patch? |
Related issue: #230 |
test this please |
1 similar comment
test this please |
Something wrong (FAILURE) |
Changed base branch to develop - all changes should go there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nitpicks.
Overall, looks good.
platform/ke02/CMakeLists.txt
Outdated
endif() | ||
|
||
# Platform is not CMSIS-compliant | ||
#set(TARGET_PLATFORM_IS_NOT_CMSIS_COMPLIANT 1 CACHE BOOL "Compliance status" FORCE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can delete these comment lines
//! @{ | ||
|
||
//! \defgroup ke02_console Console | ||
//! @{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets move addtogroup
and defgroup
statements (and corresponding @}
inside namespace { }
(The namespace itself, when included in group, looks ugly in doxygen)
platform/ke02/export/aux/uart.hpp
Outdated
template<uart_channel ch> | ||
void uart<ch>::set_tx(size_t size, uint8_t fill_byte) | ||
{ | ||
// TODO: implement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment can be also deleted
platform/ke02/export/aux/uart.hpp
Outdated
template<uart_channel ch> | ||
void uart<ch>::set_tx(size_t size, uint8_t fill_byte) | ||
{ | ||
// TODO: implement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment can be deleted
bus_ctx.status |= ctx::rx_done; | ||
} | ||
|
||
bus_ctx.h(bus_channel::meta, bus_event::tc, 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: to able to correctly process RX stream and do not miss any byte from remote device, we need to implement IRQ-based data retrieval (this is a subject to further tasks)
@@ -0,0 +1,26 @@ | |||
#ifndef KE02_PLATFORM_EXECUTION_H_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment for myself - delete this file.
@@ -0,0 +1,68 @@ | |||
#ifndef KE02_PLATFORM_IRQ_HPP_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment for myself - delete this file.
@@ -0,0 +1,4 @@ | |||
set(CMAKE_C_LINK_FLAGS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment for myself - delete this file.
@@ -0,0 +1,12 @@ | |||
# Memory layout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment for myself - delete this file.
@@ -0,0 +1,11 @@ | |||
extern "C" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment for myself - delete this file.
There were the following issues with your Pull Request
Guidelines are available at https://github.com/forGGe/theCore This message was auto-generated by https://gitcop.com |
There were the following issues with your Pull Request
Guidelines are available at https://github.com/forGGe/theCore This message was auto-generated by https://gitcop.com |
Host platform fixed to support API similar to other platforms. Example is extended to use STM32 and TM4C platform. Example code is changed to more appropriate (taken from #377)
common: fix dependency for console header
There were the following issues with your Pull Request
Guidelines are available at https://github.com/forGGe/theCore This message was auto-generated by https://gitcop.com |