Skip to content
This repository was archived by the owner on Dec 6, 2018. It is now read-only.

[WIP] Kinetis KE02 platform support #377

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from

Conversation

iia
Copy link

@iia iia commented Apr 29, 2018

  1. Add UART driver and integrate it with the bus and console layers.
  2. Working semaphore and timer configuration using internal clock.
  3. User program demonstrates console usage with delay.

forGGe and others added 22 commits February 21, 2017 20:20
Some libraries becomes optional to avoid unnecessary cloning of whole
submodules set. Architecture module is extended with possibility of
using NVIC-names interrupts. New startup assembly file is also added.
Applications can override default stubs as well as provide own library
implementation.
Without this instruction, watchdog cannot be properly re-configured.
…exp_support

Conflicts:
	CMakeLists.txt
	arch/arm_cm/CMakeLists.txt
	arch/arm_cm/startup_arm_cm.S
	build_api.cmake
	lib/CMakeLists.txt
	lib/fs/CMakeLists.txt
	lib/newlib/CMakeLists.txt
	platform/common/CMakeLists.txt
	platform/tm4c/mcu_cfg.cmake
	sys/sys.cpp
1. Add UART driver and integrate it with the bus and console layers.
2. Working semaphore and timer configuration using internal clock.
3. User program demonstrates console usage with delay.
@Dubland
Copy link
Collaborator

Dubland commented Apr 29, 2018

Can one of the admins verify this patch?

@iia iia changed the title [wip - kinetis ke02 support]: Initial support for the platform: Initial support for the Kinetis KE02 platform. Apr 29, 2018
@iia iia changed the title Initial support for the Kinetis KE02 platform. [WIP] Kinetis KE02 platform support Apr 29, 2018
@forGGe
Copy link
Collaborator

forGGe commented Apr 30, 2018

Related issue: #230

@forGGe
Copy link
Collaborator

forGGe commented Apr 30, 2018

test this please

1 similar comment
@Dubland
Copy link
Collaborator

Dubland commented Apr 30, 2018

test this please

@Dubland
Copy link
Collaborator

Dubland commented Apr 30, 2018

Something wrong (FAILURE)

@forGGe forGGe changed the base branch from g230_kinetis_ke02_exp_support to develop May 1, 2018 09:32
@forGGe
Copy link
Collaborator

forGGe commented May 1, 2018

Changed base branch to develop - all changes should go there.

Copy link
Collaborator

@forGGe forGGe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nitpicks.

Overall, looks good.

endif()

# Platform is not CMSIS-compliant
#set(TARGET_PLATFORM_IS_NOT_CMSIS_COMPLIANT 1 CACHE BOOL "Compliance status" FORCE)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete these comment lines

//! @{

//! \defgroup ke02_console Console
//! @{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets move addtogroup and defgroup statements (and corresponding @} inside namespace { }
(The namespace itself, when included in group, looks ugly in doxygen)

template<uart_channel ch>
void uart<ch>::set_tx(size_t size, uint8_t fill_byte)
{
// TODO: implement
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment can be also deleted

template<uart_channel ch>
void uart<ch>::set_tx(size_t size, uint8_t fill_byte)
{
// TODO: implement
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment can be deleted

bus_ctx.status |= ctx::rx_done;
}

bus_ctx.h(bus_channel::meta, bus_event::tc, 0);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: to able to correctly process RX stream and do not miss any byte from remote device, we need to implement IRQ-based data retrieval (this is a subject to further tasks)

@@ -0,0 +1,26 @@
#ifndef KE02_PLATFORM_EXECUTION_H_
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment for myself - delete this file.

@@ -0,0 +1,68 @@
#ifndef KE02_PLATFORM_IRQ_HPP_
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment for myself - delete this file.

@@ -0,0 +1,4 @@
set(CMAKE_C_LINK_FLAGS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment for myself - delete this file.

@@ -0,0 +1,12 @@
# Memory layout
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment for myself - delete this file.

@@ -0,0 +1,11 @@
extern "C"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment for myself - delete this file.

@GitCop
Copy link

GitCop commented May 10, 2018

There were the following issues with your Pull Request

  • Commit: 43cef80
  • Your subject line is longer than 72 characters

Guidelines are available at https://github.com/forGGe/theCore


This message was auto-generated by https://gitcop.com

@GitCop
Copy link

GitCop commented May 10, 2018

There were the following issues with your Pull Request

  • Commit: 43cef80
  • Your subject line is longer than 72 characters

Guidelines are available at https://github.com/forGGe/theCore


This message was auto-generated by https://gitcop.com

forGGe added a commit that referenced this pull request May 17, 2018
Host platform fixed to support API similar to other platforms.
Example is extended to use STM32 and TM4C platform. Example code
is changed to more appropriate (taken from
#377)
common: fix dependency for console header
@GitCop
Copy link

GitCop commented May 17, 2018

There were the following issues with your Pull Request

  • Commit: 43cef80
  • Your subject line is longer than 72 characters

Guidelines are available at https://github.com/forGGe/theCore


This message was auto-generated by https://gitcop.com

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants