tmc2209 bug fixes #755
Open
tmc2209 bug fixes #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cswank
changed the title
cswank
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this means nobody has ever used this driver for controlling a TMC2209 via uart because it panics because the buffer is too small.
Even with this fix I'm unable to turn the motor via uart, but I'm not sure why. If this PR piques someones interest in making a working example I'd be very grateful.
EDIT: I got the motor to turn. The reason turned out to be due to calculating the crc incorrectly. I pushed another commit that calculates crc according to the datasheet.