Skip to content

filemanager: Fix for issue #238 large file download error in GDP mode #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: edge
Choose a base branch
from

Conversation

Martin-Rehr
Copy link
Contributor

When in GDP mode download of largefiles fails through downloadWrapper. This fix align GDP mode with non-GDP mode and serve large files without using the 'downloadWrapper'.

@Martin-Rehr Martin-Rehr linked an issue May 5, 2025 that may be closed by this pull request
Copy link
Contributor

@jonasbardino jonasbardino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reasoning behind introducing the downloadWrapper is included in
#139
which was merged in
3766076

Basically the reworking of cat.py needs to be taken into account. By simply throwing it away I think we may e.g. again end up in the ugly case where download silently fails and produces a file with the error message in it instead of the file content.

I'm surprised that it's an issue even for the quite small files mentioned in #238 . Is it ajax blob hitting max size or how does it actually fail for such bigger files?

I don't remember if we enforce a cat size limit in production, but perhaps we should or adjust it to whatever low-enough value to force bigger downloads onto SFTP/WebDAVS if we can't fix the issue for huge files on HTTPS.

@Martin-Rehr
Copy link
Contributor Author

Martin-Rehr commented May 7, 2025

The reasoning behind introducing the downloadWrapper is included in #139 which was merged in 3766076

Basically the reworking of cat.py needs to be taken into account. By simply throwing it away I think we may e.g. again end up in the ugly case where download silently fails and produces a file with the error message in it instead of the file content.

I'm surprised that it's an issue even for the quite small files mentioned in #238 . Is it ajax blob hitting max size or how does it actually fail for such bigger files?

I don't remember if we enforce a cat size limit in production, but perhaps we should or adjust it to whatever low-enough value to force bigger downloads onto SFTP/WebDAVS if we can't fix the issue for huge files on HTTPS.

ajax chokes and show an empty error, it's not 'cat.py' that fails.

It's not feasible to restrict 'cat.py' filesizes to the 'ajax' limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File download error on web version of SIF
2 participants