-
Notifications
You must be signed in to change notification settings - Fork 301
Add additional debug logging related to JPS #8718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MattAlp
wants to merge
5
commits into
master
Choose a base branch
from
mattalp/additional-jvmstat-telemetry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 68 metrics, 3 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~c06bf67bf3, baseline=1.49.0-SNAPSHOT~12da6fe499
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.008 s) : 0, 1008228
Total [baseline] (8.641 s) : 0, 8641291
Agent [candidate] (1.004 s) : 0, 1003834
Total [candidate] (8.612 s) : 0, 8612365
section iast
Agent [baseline] (1.132 s) : 0, 1132408
Total [baseline] (9.189 s) : 0, 9188674
Agent [candidate] (1.147 s) : 0, 1147046
Total [candidate] (9.204 s) : 0, 9204269
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.137 s) : 0, 1136656
Total [baseline] (9.192 s) : 0, 9191543
Agent [candidate] (1.147 s) : 0, 1146782
Total [candidate] (9.197 s) : 0, 9196689
section iast_TELEMETRY_OFF
Agent [baseline] (1.136 s) : 0, 1135731
Total [baseline] (9.179 s) : 0, 9179008
Agent [candidate] (1.148 s) : 0, 1148157
Total [candidate] (9.2 s) : 0, 9200368
gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~c06bf67bf3, baseline=1.49.0-SNAPSHOT~12da6fe499
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.089 ms) : 0, 672089
BytebuddyAgent [candidate] (669.258 ms) : 0, 669258
GlobalTracer [baseline] (240.394 ms) : 0, 240394
GlobalTracer [candidate] (239.328 ms) : 0, 239328
AppSec [baseline] (54.776 ms) : 0, 54776
AppSec [candidate] (54.466 ms) : 0, 54466
Debugger [baseline] (6.17 ms) : 0, 6170
Debugger [candidate] (6.158 ms) : 0, 6158
Remote Config [baseline] (704.621 µs) : 0, 705
Remote Config [candidate] (696.18 µs) : 0, 696
Telemetry [baseline] (10.728 ms) : 0, 10728
Telemetry [candidate] (10.564 ms) : 0, 10564
section iast
BytebuddyAgent [baseline] (786.904 ms) : 0, 786904
BytebuddyAgent [candidate] (797.709 ms) : 0, 797709
GlobalTracer [baseline] (229.234 ms) : 0, 229234
GlobalTracer [candidate] (231.653 ms) : 0, 231653
IAST [baseline] (22.626 ms) : 0, 22626
IAST [candidate] (22.994 ms) : 0, 22994
AppSec [baseline] (56.169 ms) : 0, 56169
AppSec [candidate] (56.723 ms) : 0, 56723
Debugger [baseline] (5.805 ms) : 0, 5805
Debugger [candidate] (5.9 ms) : 0, 5900
Remote Config [baseline] (586.713 µs) : 0, 587
Remote Config [candidate] (597.887 µs) : 0, 598
Telemetry [baseline] (7.805 ms) : 0, 7805
Telemetry [candidate] (7.96 ms) : 0, 7960
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (789.165 ms) : 0, 789165
BytebuddyAgent [candidate] (797.157 ms) : 0, 797157
GlobalTracer [baseline] (230.104 ms) : 0, 230104
GlobalTracer [candidate] (231.699 ms) : 0, 231699
IAST [baseline] (22.921 ms) : 0, 22921
IAST [candidate] (23.127 ms) : 0, 23127
AppSec [baseline] (56.63 ms) : 0, 56630
AppSec [candidate] (56.549 ms) : 0, 56549
Debugger [baseline] (5.904 ms) : 0, 5904
Debugger [candidate] (5.951 ms) : 0, 5951
Remote Config [baseline] (596.494 µs) : 0, 596
Remote Config [candidate] (605.5 µs) : 0, 606
Telemetry [baseline] (7.904 ms) : 0, 7904
Telemetry [candidate] (7.964 ms) : 0, 7964
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (790.008 ms) : 0, 790008
BytebuddyAgent [candidate] (799.626 ms) : 0, 799626
GlobalTracer [baseline] (229.526 ms) : 0, 229526
GlobalTracer [candidate] (231.867 ms) : 0, 231867
IAST [baseline] (22.227 ms) : 0, 22227
IAST [candidate] (22.482 ms) : 0, 22482
AppSec [baseline] (56.218 ms) : 0, 56218
AppSec [candidate] (56.276 ms) : 0, 56276
Debugger [baseline] (5.961 ms) : 0, 5961
Debugger [candidate] (5.874 ms) : 0, 5874
Remote Config [baseline] (600.266 µs) : 0, 600
Remote Config [candidate] (589.49 µs) : 0, 589
Telemetry [baseline] (7.712 ms) : 0, 7712
Telemetry [candidate] (7.778 ms) : 0, 7778
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~c06bf67bf3, baseline=1.49.0-SNAPSHOT~12da6fe499
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.011 s) : 0, 1010555
Total [baseline] (10.509 s) : 0, 10509027
Agent [candidate] (1.013 s) : 0, 1013021
Total [candidate] (10.491 s) : 0, 10490810
section appsec
Agent [baseline] (1.15 s) : 0, 1149878
Total [baseline] (10.688 s) : 0, 10687648
Agent [candidate] (1.162 s) : 0, 1161951
Total [candidate] (10.774 s) : 0, 10773731
section iast
Agent [baseline] (1.137 s) : 0, 1136672
Total [baseline] (10.869 s) : 0, 10868505
Agent [candidate] (1.136 s) : 0, 1135998
Total [candidate] (10.807 s) : 0, 10806652
section profiling
Agent [baseline] (1.255 s) : 0, 1255102
Total [baseline] (10.777 s) : 0, 10776942
Agent [candidate] (1.255 s) : 0, 1255322
Total [candidate] (10.847 s) : 0, 10847265
gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~c06bf67bf3, baseline=1.49.0-SNAPSHOT~12da6fe499
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.258 ms) : 0, 674258
BytebuddyAgent [candidate] (674.683 ms) : 0, 674683
GlobalTracer [baseline] (241.102 ms) : 0, 241102
GlobalTracer [candidate] (241.349 ms) : 0, 241349
AppSec [baseline] (54.875 ms) : 0, 54875
AppSec [candidate] (55.049 ms) : 0, 55049
Debugger [baseline] (6.227 ms) : 0, 6227
Debugger [candidate] (6.208 ms) : 0, 6208
Remote Config [baseline] (711.156 µs) : 0, 711
Remote Config [candidate] (713.996 µs) : 0, 714
Telemetry [baseline] (9.887 ms) : 0, 9887
Telemetry [candidate] (11.292 ms) : 0, 11292
section appsec
BytebuddyAgent [baseline] (688.873 ms) : 0, 688873
BytebuddyAgent [candidate] (696.59 ms) : 0, 696590
GlobalTracer [baseline] (236.94 ms) : 0, 236940
GlobalTracer [candidate] (239.239 ms) : 0, 239239
IAST [baseline] (21.774 ms) : 0, 21774
IAST [candidate] (22.372 ms) : 0, 22372
AppSec [baseline] (174.71 ms) : 0, 174710
AppSec [candidate] (176.835 ms) : 0, 176835
Debugger [baseline] (5.894 ms) : 0, 5894
Debugger [candidate] (5.938 ms) : 0, 5938
Remote Config [baseline] (629.406 µs) : 0, 629
Remote Config [candidate] (647.597 µs) : 0, 648
Telemetry [baseline] (8.543 ms) : 0, 8543
Telemetry [candidate] (7.856 ms) : 0, 7856
section iast
BytebuddyAgent [baseline] (790.09 ms) : 0, 790090
BytebuddyAgent [candidate] (789.057 ms) : 0, 789057
GlobalTracer [baseline] (229.96 ms) : 0, 229960
GlobalTracer [candidate] (230.031 ms) : 0, 230031
IAST [baseline] (22.864 ms) : 0, 22864
IAST [candidate] (22.73 ms) : 0, 22730
AppSec [baseline] (55.97 ms) : 0, 55970
AppSec [candidate] (56.397 ms) : 0, 56397
Debugger [baseline] (5.908 ms) : 0, 5908
Debugger [candidate] (5.908 ms) : 0, 5908
Remote Config [baseline] (601.35 µs) : 0, 601
Remote Config [candidate] (577.927 µs) : 0, 578
Telemetry [baseline] (7.873 ms) : 0, 7873
Telemetry [candidate] (7.85 ms) : 0, 7850
section profiling
BytebuddyAgent [baseline] (661.231 ms) : 0, 661231
BytebuddyAgent [candidate] (661.187 ms) : 0, 661187
GlobalTracer [baseline] (378.067 ms) : 0, 378067
GlobalTracer [candidate] (378.091 ms) : 0, 378091
AppSec [baseline] (54.681 ms) : 0, 54681
AppSec [candidate] (53.996 ms) : 0, 53996
Debugger [baseline] (6.115 ms) : 0, 6115
Debugger [candidate] (6.141 ms) : 0, 6141
Remote Config [baseline] (640.727 µs) : 0, 641
Remote Config [candidate] (650.917 µs) : 0, 651
Telemetry [baseline] (8.124 ms) : 0, 8124
Telemetry [candidate] (8.161 ms) : 0, 8161
ProfilingAgent [baseline] (95.983 ms) : 0, 95983
ProfilingAgent [candidate] (96.233 ms) : 0, 96233
Profiling [baseline] (96.008 ms) : 0, 96008
Profiling [candidate] (96.256 ms) : 0, 96256
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~c06bf67bf3, baseline=1.49.0-SNAPSHOT~12da6fe499
dateFormat X
axisFormat %s
section baseline
no_agent (385.2 µs) : 365, 405
. : milestone, 385,
iast (527.234 µs) : 504, 551
. : milestone, 527,
iast_FULL (739.119 µs) : 716, 763
. : milestone, 739,
iast_GLOBAL (584.848 µs) : 561, 609
. : milestone, 585,
iast_HARDCODED_SECRET_DISABLED (533.546 µs) : 511, 556
. : milestone, 534,
iast_INACTIVE (479.967 µs) : 457, 503
. : milestone, 480,
iast_TELEMETRY_OFF (512.072 µs) : 489, 535
. : milestone, 512,
tracing (471.028 µs) : 449, 493
. : milestone, 471,
section candidate
no_agent (388.311 µs) : 368, 408
. : milestone, 388,
iast (525.828 µs) : 503, 549
. : milestone, 526,
iast_FULL (743.83 µs) : 720, 767
. : milestone, 744,
iast_GLOBAL (568.948 µs) : 546, 592
. : milestone, 569,
iast_HARDCODED_SECRET_DISABLED (518.738 µs) : 496, 542
. : milestone, 519,
iast_INACTIVE (478.406 µs) : 456, 501
. : milestone, 478,
iast_TELEMETRY_OFF (510.156 µs) : 487, 533
. : milestone, 510,
tracing (469.269 µs) : 447, 491
. : milestone, 469,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~c06bf67bf3, baseline=1.49.0-SNAPSHOT~12da6fe499
dateFormat X
axisFormat %s
section baseline
no_agent (1.37 ms) : 1350, 1391
. : milestone, 1370,
appsec (1.748 ms) : 1725, 1772
. : milestone, 1748,
appsec_no_iast (1.748 ms) : 1723, 1772
. : milestone, 1748,
code_origins (1.672 ms) : 1645, 1699
. : milestone, 1672,
iast (1.532 ms) : 1509, 1556
. : milestone, 1532,
profiling (1.524 ms) : 1501, 1547
. : milestone, 1524,
tracing (1.508 ms) : 1483, 1533
. : milestone, 1508,
section candidate
no_agent (1.391 ms) : 1372, 1410
. : milestone, 1391,
appsec (1.754 ms) : 1730, 1778
. : milestone, 1754,
appsec_no_iast (1.738 ms) : 1715, 1762
. : milestone, 1738,
code_origins (1.714 ms) : 1686, 1743
. : milestone, 1714,
iast (1.528 ms) : 1504, 1553
. : milestone, 1528,
profiling (1.569 ms) : 1544, 1593
. : milestone, 1569,
tracing (1.507 ms) : 1482, 1533
. : milestone, 1507,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~c06bf67bf3, baseline=1.49.0-SNAPSHOT~12da6fe499
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (2.394 ms) : 2346, 2442
. : milestone, 2394,
iast (2.171 ms) : 2111, 2231
. : milestone, 2171,
iast_GLOBAL (2.22 ms) : 2159, 2281
. : milestone, 2220,
profiling (2.043 ms) : 1994, 2092
. : milestone, 2043,
tracing (1.991 ms) : 1944, 2037
. : milestone, 1991,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.401 ms) : 2353, 2449
. : milestone, 2401,
iast (2.169 ms) : 2109, 2229
. : milestone, 2169,
iast_GLOBAL (2.215 ms) : 2155, 2276
. : milestone, 2215,
profiling (2.018 ms) : 1970, 2065
. : milestone, 2018,
tracing (1.991 ms) : 1945, 2037
. : milestone, 1991,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~c06bf67bf3, baseline=1.49.0-SNAPSHOT~12da6fe499
dateFormat X
axisFormat %s
section baseline
no_agent (14.669 s) : 14669000, 14669000
. : milestone, 14669000,
appsec (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
iast (19.271 s) : 19271000, 19271000
. : milestone, 19271000,
iast_GLOBAL (17.809 s) : 17809000, 17809000
. : milestone, 17809000,
profiling (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
tracing (15.145 s) : 15145000, 15145000
. : milestone, 15145000,
section candidate
no_agent (15.591 s) : 15591000, 15591000
. : milestone, 15591000,
appsec (14.991 s) : 14991000, 14991000
. : milestone, 14991000,
iast (19.14 s) : 19140000, 19140000
. : milestone, 19140000,
iast_GLOBAL (17.952 s) : 17952000, 17952000
. : milestone, 17952000,
profiling (14.952 s) : 14952000, 14952000
. : milestone, 14952000,
tracing (15.029 s) : 15029000, 15029000
. : milestone, 15029000,
|
Re-associating this with PROF-11678 |
jbachorik
approved these changes
Apr 22, 2025
7 tasks
amarziali
approved these changes
Apr 30, 2025
76ce22c
to
c06bf67
Compare
smola
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Records via telemetry if the
jvmstat
module isn't found, for observability across different JVM distributionstype:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: PROF-11678