Skip to content

Add additional debug logging related to JPS #8718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.continue.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ instrumentation_modules: &instrumentation_modules "dd-java-agent/instrumentation
debugger_modules: &debugger_modules "dd-java-agent/agent-debugger|dd-java-agent/agent-bootstrap|dd-java-agent/agent-builder|internal-api|communication|dd-trace-core"
profiling_modules: &profiling_modules "dd-java-agent/agent-profiling"

default_system_tests_commit: &default_system_tests_commit b0b2e1f212f8c483b52aa3adc6ffd4132b1ba9b8
default_system_tests_commit: &default_system_tests_commit 9049791de92dcb72b104e99a80f6f9914c1b96fb

parameters:
nightly:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
package datadog.trace.util;

import static datadog.trace.api.telemetry.LogCollector.SEND_TELEMETRY;

import datadog.trace.api.Platform;
import java.lang.instrument.Instrumentation;
import java.util.Collections;
import java.util.Map;
import java.util.Set;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class JPMSJPSAccess {
private static Logger log = LoggerFactory.getLogger(JPMSJPSAccess.class);

public static void patchModuleAccess(Instrumentation inst) {
Module unnamedModule = ClassLoader.getSystemClassLoader().getUnnamedModule();
Module jvmstatModule = ModuleLayer.boot().findModule("jdk.internal.jvmstat").orElse(null);
Expand All @@ -21,6 +28,13 @@ public static void patchModuleAccess(Instrumentation inst) {
extraOpens,
Collections.emptySet(),
Collections.emptyMap());
} else {
log.debug(
SEND_TELEMETRY,
"Failed to find the jdk.internal.jvmstat module, skipping patching of module access on "
+ Platform.getRuntimeVersion()
+ " "
+ Platform.getRuntimeVendor());
}
}
}
Loading