Skip to content

feat: Add support for Amazon AWS and Google Drive #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Ijv3-0
Copy link
Contributor

@Ijv3-0 Ijv3-0 commented Mar 21, 2025

Description

Currently, datashuttle supports transferring projects between local filesystems and remote systems via SSH. To enhance usability and data-sharing, we need to extend datashuttle to support file transfers via AWS S3 and Google Drive using RClone.

  • Extend TUI: Modify the existing terminal user interface (TUI) to support AWS S3 and Google Drive in a similar style to SSH.
  • Update Python API: Implement AWS S3 and Google Drive transfer functionality using RClone.
  • Dynamic UI Rendering: When a user selects AWS S3 or Google Drive, the respective input fields should appear dynamically

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Addresses #407

References

fixes #407

How has this PR been tested?

Launched datashuttle using the command
Screenshot 2025-03-21 223448

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@Ijv3-0
Copy link
Contributor Author

Ijv3-0 commented Mar 21, 2025

@JoeZiminski Please validate my steps, if this looks smooth I can try it out and test properly.

@JoeZiminski
Copy link
Member

Hi @Ijv3-0 thanks a lot for this! this looks really cool. I will have a look as soon as possible, I am on paternity leave starting from Monday so it might take longer than usual to respond. Don't worry in terms of GSoC about merging, it does not matter if the PR is merged in terms of contributions. I will take a look at this ASAP, thanks!

@Ijv3-0
Copy link
Contributor Author

Ijv3-0 commented Mar 23, 2025

@JoeZiminski Hi! Thanks a lot for your time and feedback—I really appreciate it! No worries at all, and congrats on your paternity leave! Wishing you all the best during this special time. I'll be here whenever you get a chance to take a look. Thanks again!

@Ijv3-0
Copy link
Contributor Author

Ijv3-0 commented Apr 26, 2025

Hi @JoeZiminski,
I opened this PR a month ago, and you mentioned you would take a look as soon as possible. However, I haven't received any review yet. Since the PR now has many merge conflicts, I need to close it and open a new PR that works properly.
We can continue our discussion there.
Could you please review that new PR when you get a chance? Thank you!

@adamltyson
Copy link
Member

Thanks for pushing this forwards while @JoeZiminski is away. However, in future would you mind keeping everything in one PR? It makes it a lot harder for us to keep track of things if there are duplicate PRs. It also makes us less likely to review your PR quickly, as we often aim to review the oldest PRs first!

@Ijv3-0
Copy link
Contributor Author

Ijv3-0 commented Apr 29, 2025

Thanks for the clarification, @adamltyson — that makes sense. I only opened a new PR because the original had many conflicts, but I understand how it affects your workflow. I’ll make sure to keep everything in a single PR moving forward. Appreciate the heads-up and looking forward to your review!

@adamltyson
Copy link
Member

FYI if you want to "start again", you can just force push a new version to the same branch. That way you can keep the same PR, but not worry about the old conflicts.

@Ijv3-0
Copy link
Contributor Author

Ijv3-0 commented Apr 29, 2025

Got it — thanks for the tip, @adamltyson! I’ll use force-push to update the same branch next time to avoid opening a new PR. Appreciate your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Amazon AWS and Google Drive
3 participants