Skip to content

[3.0.1] Improve PUA startup time #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

yengliong93
Copy link
Contributor

@yengliong93 yengliong93 commented Apr 17, 2025

Description

This PR improves the PUA startup time by:

  • Removing the startup operation that deletes sotaSW:docker in INBM configuration file, as there was a long timeout issue observed during this operation.

There is a timeout issue observed in this operation, which is delaying the overall PUA bring-up time. The purpose of this operation is to modify the INBM configuration file to remove certain software checks during system update. We decide to remove this operation from the PUA and let the OM to handle it.

Fixes # (issue)

Any Newly Introduced Dependencies

Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I agree to use the APACHE-2.0 license for my code changes
  • I have not introduced any 3rd party dependency changes
  • I have performed a self-review of my code

@cjnolan
Copy link
Contributor

cjnolan commented Apr 17, 2025

Should be merged after #22 to allow the logs to be viewable

@yengliong93 yengliong93 changed the title Increase PUA startup time Improve PUA startup time Apr 18, 2025
@yengliong93
Copy link
Contributor Author

Hi @cjnolan , there is an error in Lint manifest CI/CD. Do we need to update any other files?

ERROR: Duplicate tag: ena-manifest/1.0.0
Initial version of manifest file, skip check
Error: Process completed with exit code 2.

@Ram-srini Ram-srini changed the title Improve PUA startup time [3.0.1] Improve PUA startup time Apr 23, 2025
@rranjan3
Copy link
Contributor

Hi @cjnolan , there is an error in Lint manifest CI/CD. Do we need to update any other files?

ERROR: Duplicate tag: ena-manifest/1.0.0
Initial version of manifest file, skip check
Error: Process completed with exit code 2.

We can bump to 1.0.1-dev

@Ram-srini Ram-srini added 3.0.1 Cherry-pick PR for 3.0.1 c-3.0.1 Candidate PR for 3.0.1 labels Apr 29, 2025
@pierventre
Copy link
Contributor

why are we reducing the ticker interval? cc @daniele-moro and @raphaelvrosa this has an implication for scale and simulation of the agents.

Can you elaborate why is it necessary?

@yengliong93
Copy link
Contributor Author

why are we reducing the ticker interval? cc @daniele-moro and @raphaelvrosa this has an implication for scale and simulation of the agents.

Can you elaborate why is it necessary?

The changes of tickerInterval has been reverted. PR description updated. Theoretically, a shorter tickerInterval allows the PUA to receive a response from MM more quickly, enabling it to send the READY status heartbeat faster. However, after testing, we found it only saves 10 seconds, so we decided to revert the changes.

@yengliong93 yengliong93 requested a review from krishnajs as a code owner May 8, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0.1 Cherry-pick PR for 3.0.1 c-3.0.1 Candidate PR for 3.0.1 platform-update-agent root
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants