Skip to content

[3.0.1] Improve PUA startup time #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[3.0.1] Improve PUA startup time #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a6a57ff
Increase PUA startup time
yengliong93 Apr 17, 2025
bf95019
Merge branch 'main' into optimize-pua-startup-time
Ram-srini Apr 23, 2025
da7dfcb
bump manifest to 1.0.1-dev
yengliong93 Apr 28, 2025
0e5d53f
Revert tickerInterval to 20s
yengliong93 Apr 29, 2025
f75a4fe
Update ena-manifest to 1.0.1
yengliong93 Apr 29, 2025
72b9df4
Fix unit test
yengliong93 May 8, 2025
3a04ecb
Merge branch 'main' into optimize-pua-startup-time
yengliong93 May 8, 2025
fab16cb
Update version and ena-manifest
yengliong93 May 8, 2025
46c52aa
Update ena-manifest.yaml
yengliong93 May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ena-manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ packages:
version: 1.3.1
ociArtifact: edge-orch/en/deb/platform-telemetry-agent
- name: platform-update-agent
version: 1.4.2
version: 1.5.0
ociArtifact: edge-orch/en/deb/platform-update-agent
- name: caddy
version: 2.7.6
Expand Down
2 changes: 1 addition & 1 deletion platform-update-agent/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.5.0-dev
1.5.0
4 changes: 0 additions & 4 deletions platform-update-agent/internal/installer/installer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,6 @@ func (i *Installer) ProvisionInbm(ctx context.Context) error {
return fmt.Errorf("failed to execute shell command - %v", err)
}

if err := i.modifyConfiguration(ctx); err != nil {
return fmt.Errorf("failed to modify INBC configuration - %v", err)
}

file, err := os.Create(inbmConfigSuccessPath)
if err != nil {
log.Errorf("Creating file failed: %s", inbmConfigSuccessPath)
Expand Down
10 changes: 0 additions & 10 deletions platform-update-agent/internal/installer/installer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,6 @@ func TestInbm_ProvisionInbm_IfAlreadyProvisionedShouldDoNothing(t *testing.T) {

func TestInbm_ProvisionInbm_HappyPath(t *testing.T) {
var provisionTcCommandCalled bool
var removeDockerCommandCalled bool
var restartInbmConfigurationCommandCalled bool

inbmConfigSuccessPath = "testdata/.notconfigured"
defer os.Remove(inbmConfigSuccessPath)
Expand All @@ -235,12 +233,6 @@ func TestInbm_ProvisionInbm_HappyPath(t *testing.T) {
case reflect.DeepEqual(*args, provisionTcCommand):
provisionTcCommandCalled = true
return nil, nil
case reflect.DeepEqual(*args, removeDockerCommand):
removeDockerCommandCalled = true
return nil, nil
case reflect.DeepEqual(*args, restartInbmConfigurationCommand):
restartInbmConfigurationCommandCalled = true
return nil, nil
}
return nil, nil
})
Expand All @@ -251,8 +243,6 @@ func TestInbm_ProvisionInbm_HappyPath(t *testing.T) {

require.NoError(t, sut(context.TODO()))
require.Truef(t, provisionTcCommandCalled, "provisionTcCommand function shall be called")
require.Truef(t, removeDockerCommandCalled, "removeDockerCommand function shall be called")
require.Truef(t, restartInbmConfigurationCommandCalled, "restartInbmConfigurationCommand function shall be called")
_, err := os.Stat(inbmConfigSuccessPath)
require.NoError(t, err)
}
Expand Down