Github actions: Build shared and shared versioned #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced qualisys_cpp_sdk_BUILD_SHARED and qualisys_cpp_sdk_BUILD_SHARED_VERSIONED with qualisys_cpp_sdk_OUTPUT_TYPE
OliverGlandberger
approved these changes
Feb 20, 2025
qjgn
merged commit 4624836
into
dynamic_build_fPiC_flag_and_release_suffix_option
10 checks passed
OliverGlandberger
added a commit
that referenced
this pull request
Feb 20, 2025
…113) * Initial solution, built on the previous solution. Tested on Windows. * Updated comments, reintroduced previously removed code. * Remove unnecessary comment. * Move 'independent code' line above tinyxml2 code. * Add default-build as 'release' if not specified. * Update to use correct 'tinyxml2_SHARED_LIBS' tag. * Updated CMakeList.txt files so that we can run tests when building as dynamic, also made tinyxml2 always build as static. * Update Windows-specific linking to be less strict so that Clang has access to required code. * Remove tinyxml2 block that should have been removed in merge. * Github actions: Build shared and shared versioned (#119) * Added cmake parameter qualisys_cpp_sdk_OUTPUT_TYPE Replaced qualisys_cpp_sdk_BUILD_SHARED and qualisys_cpp_sdk_BUILD_SHARED_VERSIONED with qualisys_cpp_sdk_OUTPUT_TYPE * Added output_type to build actions * Add quotation marks for the sake of consistency. * Remove if-win32 check, add check to library includes directly. * Remove if-win32 check, add check to library includes directly. --------- Co-authored-by: qjgn <45095781+qjgn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
qualisys_cpp_sdk_BUILD_SHAREDandqualisys_cpp_sdk_BUILD_SHARED_VERSIONEDWith a new single option:
qualisys_cpp_sdk_OUTPUT_TYPEAdded output_type to build actions matrix for testing